[FXC-6484] Add CADDesignIntent model and design_intent field to GeometryEntityInfo#1946
Open
andrzej-krupka wants to merge 1 commit intomainfrom
Open
[FXC-6484] Add CADDesignIntent model and design_intent field to GeometryEntityInfo#1946andrzej-krupka wants to merge 1 commit intomainfrom
andrzej-krupka wants to merge 1 commit intomainfrom
Conversation
…-6484] - Add CADDesignIntent Pydantic model (design_intent.py) representing the feature tree extracted from native CAD formats - Add optional design_intent field to GeometryEntityInfo; populated only when the geometry was imported from a format that exposes the feature tree - Remove entity_id from BodyComponentInfo (no longer needed after per-occurrence UUID assignment in CADToGeometry) Co-Authored-By: claude-flow <ruv@ruv.net>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CADDesignIntentPydantic model (design_intent.py): represents the feature tree extracted from native CAD formats (features with name, type, parameters, and child features).design_intentfield toGeometryEntityInfo: optional, populated only when the geometry was imported from a native format that exposes the feature tree.entity_idfromBodyComponentInfo: no longer needed after per-occurrence UUID assignment is handled inCADToGeometry --instanced(compute-side change, flexcompute/compute#4412).Test plan
GeometryEntityInfoserializes/deserializes withdesign_intent: nullfor STEP importsGeometryEntityInfoserializes/deserializes with populateddesign_intentfor native CAD importsentity_idfield🤖 Generated with claude-flow
Note
Medium Risk
Adds a new optional
design_intentpayload toGeometryEntityInfo, which changes the entity-info JSON schema and could affect serialization/compatibility for geometry metadata consumers.Overview
Introduces a new
CADDesignIntent/CADFeaturePydantic model (design_intent.py) to represent native-CAD feature-tree metadata, including feature relationships, referenced/produced entity IDs, and parameter properties.Extends
GeometryEntityInfoto optionally carry this metadata via a newdesign_intent: Optional[CADDesignIntent]field, enabling entity-info JSON to include feature-tree context when available while remainingnullfor formats without it.Written by Cursor Bugbot for commit a12ce04. This will update automatically on new commits. Configure here.